Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask users if they'd like to have default taints added to the user and worker node groups of Nebari for potential cost savings #2824

Open
Adam-D-Lewis opened this issue Nov 4, 2024 · 3 comments

Comments

@Adam-D-Lewis
Copy link
Member

Context

#2605 adds taints to user nodes to fix issues in the past where node groups won't scale down. This is a nice benefit and would result in cost savings for most users. However most prior users won't know about the change unless we prompt them about it during the upgrade process.

Value and/or benefit

good defaults for existing users resulting in cost savings

Anything else?

No response

@Adam-D-Lewis Adam-D-Lewis added the needs: triage 🚦 Someone needs to have a look at this issue and triage label Nov 4, 2024
@Adam-D-Lewis Adam-D-Lewis added this to the 2024.11.2 release milestone Nov 4, 2024
@Adam-D-Lewis Adam-D-Lewis added area: cost controls and removed needs: triage 🚦 Someone needs to have a look at this issue and triage labels Nov 5, 2024
@Adam-D-Lewis
Copy link
Member Author

Keep in mind that other user node groups (e.g. gpus, argo workflows using jupyterflow-override) should add the user taint to other user node profiles in order to prevent the same issue this PR prevents.

@viniciusdc
Copy link
Contributor

@Adam-D-Lewis, will #2605 address this consideration?

@Adam-D-Lewis
Copy link
Member Author

Adam-D-Lewis commented Dec 12, 2024

This comment addresses this need since taints will be applied by default. We should add a note in the upgrade step to saying nodes will be restarted during the upgrade though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: New 🚦
Development

No branches or pull requests

2 participants