Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong mention of jupyterhub managed service #527

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix wrong mention of jupyterhub managed service #527

wants to merge 1 commit into from

Conversation

viniciusdc
Copy link
Contributor

@viniciusdc viniciusdc commented Nov 13, 2024 •
edited
Loading

Reference Issues or PRs

closes #526

What does this implement/fix?

There was an error in which type of jupyterhub service JhubAps belonged to

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

@vercel Vercel
Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jhub-apps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 4:51pm
jhub-apps-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 4:51pm

@viniciusdc viniciusdc requested a review from aktech November 13, 2024 16:51
@viniciusdc
Copy link
Contributor Author

viniciusdc commented Nov 13, 2024 •
edited
Loading

the rest of the docs is correct, just that part was wrong... funny enough, just after that line I say its a hub managed service and even described the command that is executed

aktech
aktech requested changes Nov 14, 2024
View reviewed changes
Copy link
Member

@aktech aktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, other than a minor grammar nitpick.

docs/docs/concepts/infrastructure-architecture.mdx
@@ -4,7 +4,7 @@ sidebar_position: 1

# Infrastructure Architecture

JHub Apps, also known as JupyterHub (JHub) App Launcher, is an [Externally-Managed JupyterHub service](https://jupyterhub.readthedocs.io/en/stable/reference/services.html#externally-managed-services) designed to enable users to launch various server types including API services, any generic Python command, standard JupyterLab instances, and dashboards such as Panel, Bokeh, and Streamlit.
JHub Apps, also known as JupyterHub (JHub) App Launcher, is an [JupyterHub-Managed Service](https://jupyterhub.readthedocs.io/en/stable/reference/services.html#launching-a-hub-managed-service) designed to enable users to launch various server types including API services, any generic Python command, standard JupyterLab instances, and dashboards such as Panel, Bokeh, and Streamlit.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
JHub Apps, also known as JupyterHub (JHub) App Launcher, is an [JupyterHub-Managed Service](https://jupyterhub.readthedocs.io/en/stable/reference/services.html#launching-a-hub-managed-service) designed to enable users to launch various server types including API services, any generic Python command, standard JupyterLab instances, and dashboards such as Panel, Bokeh, and Streamlit.
JHub Apps, also known as JupyterHub (JHub) App Launcher, is a [JupyterHub-Managed Service](https://jupyterhub.readthedocs.io/en/stable/reference/services.html#launching-a-hub-managed-service) designed to enable users to launch various server types including API services, any generic Python command, standard JupyterLab instances, and dashboards such as Panel, Bokeh, and Streamlit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aktech aktech aktech requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC] - Fix docs to say this is a hub managed jupyherhub service
2 participants
@viniciusdc @aktech