Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Total Funding Field' on candidate page includes all tranasction types #182

Closed
SchaeStewart opened this issue Oct 29, 2020 · 0 comments · May be fixed by #302
Closed

'Total Funding Field' on candidate page includes all tranasction types #182

SchaeStewart opened this issue Oct 29, 2020 · 0 comments · May be fixed by #302
Assignees
Labels
backend bug Something isn't working data

Comments

@SchaeStewart
Copy link
Contributor

SchaeStewart commented Oct 29, 2020

Problem

The Total Funding Field on the candidate page is calculated without accounting for transaction types. For example, it counts refunds and individual contributions. From what I can tell, this is not the behavior we want.

Solution

Identify which transaction types need to be included in the sum calculation.

From the DB I see there are 12 transaction types:

+--------------------+
|transaction_type    |
+--------------------+
|Interest            |
|Contrib to Reimburse|
|Nonprofit           |
|Non-Party Comm      |
|Refund              |
|Outside Source      |
|Loan                |
|Individual          |
|General             |
|Party Comm          |
|Forgiven Loan       |
|Outstanding Loan    |
+--------------------+

Do all of these need to be included?

Todo:

  • Change refund values to negative in ETL script OR subtract refund values from total
  • Exclude Interest transaction type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working data
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants