Plugin is not robust to HTTP failures

[1ma]

If trustedcoin doesn't receive an HTTP 200 response from one of the external data sources it crashes the lightningd process. Not sure at this point if this only affects the estimatefees RPC method or all of them.

I'll try to tackle this one, too.

$ docker run --rm -it 1maa/core-lightning:latest
2024-07-12T19:49:19.747Z INFO    lightningd: v24.05
2024-07-12T19:49:19.765Z INFO    plugin-manager: /usr/local/libexec/c-lightning/plugins/bcli: disabled via disable-plugin
2024-07-12T19:49:19.794Z INFO    plugin-clnrest: Killing plugin: disabled itself: No python3 binary found
2024-07-12T19:49:19.794Z INFO    plugin-wss-proxy: Killing plugin: disabled itself: No python3 binary found
2024-07-12T19:49:19.799Z INFO    lightningd: Creating database
2024-07-12T19:49:19.837Z UNUSUAL hsmd: HSM: created new hsm_secret file
2024-07-12T19:49:19.888Z plugin-trustedcoin initialized plugin 0.8.0
2024-07-12T19:49:19.888Z plugin-trustedcoin bitcoind RPC settings not detected (looked for 'bitcoin-rpcuser', 'bitcoin-rpcpassword' and optionally 'bitcoin-rpcconnect' and 'bitcoin-rpcport'), will only use block explorers.
2024-07-12T19:49:20.006Z plugin-trustedcoin tip: 851876
2024-07-12T19:49:33.521Z plugin-trustedcoin returning block 851861, 00000000000000000001890b67…, 1494623 bytes
2024-07-12T19:49:33.582Z INFO    plugin-chanbackup: Creating Emergency Recovery
2024-07-12T19:49:33.584Z INFO    plugin-bookkeeper: Creating database
2024-07-12T19:49:33.610Z plugin-trustedcoin tip: 851876
2024-07-12T19:49:33.611Z INFO    lightningd: --------------------------------------------------
2024-07-12T19:49:33.611Z INFO    lightningd: Server started with public key 03d87c16b14f42cb876f23cef15596b89275bea65aaec32b3a470e5c05dc7a96c1, alias CHILLYTRAWL (color #03d87c) and lightningd v24.05
2024-07-12T19:49:42.973Z plugin-trustedcoin returning block 851862, 000000000000000000000dfc2c…, 1503350 bytes
2024-07-12T19:50:29.856Z plugin-trustedcoin returning block 851863, 0000000000000000000182a6de…, 1447487 bytes
2024-07-12T19:50:56.131Z plugin-trustedcoin returning block 851864, 00000000000000000002e8ce42…, 1614515 bytes
2024-07-12T19:50:58.942Z plugin-trustedcoin returning block 851865, 000000000000000000010f196d…, 1597037 bytes
2024-07-12T19:51:42.508Z plugin-trustedcoin returning block 851866, 0000000000000000000201c0f7…, 1707721 bytes
2024-07-12T19:51:48.176Z plugin-trustedcoin returning block 851867, 00000000000000000000de29a1…, 1560458 bytes
2024-07-12T19:51:55.402Z plugin-trustedcoin returning block 851868, 00000000000000000001a3b53d…, 1404142 bytes
2024-07-12T19:51:57.866Z plugin-trustedcoin returning block 851869, 00000000000000000001240b38…, 1675413 bytes
2024-07-12T19:53:43.509Z plugin-trustedcoin returning block 851870, 00000000000000000002cc27fe…, 1753985 bytes
2024-07-12T19:53:54.136Z plugin-trustedcoin returning block 851871, 0000000000000000000186fc88…, 1429308 bytes
2024-07-12T19:53:54.929Z plugin-trustedcoin returning block 851872, 0000000000000000000112a0a9…, 1476175 bytes
2024-07-12T19:53:59.954Z plugin-trustedcoin returning block 851873, 0000000000000000000343747d…, 1639433 bytes
2024-07-12T19:55:40.753Z plugin-trustedcoin returning block 851874, 00000000000000000001eac16f…, 1611430 bytes
2024-07-12T19:55:45.498Z plugin-trustedcoin returning block 851875, 000000000000000000002427bf…, 1581768 bytes
2024-07-12T19:56:15.875Z plugin-trustedcoin returning block 851876, 00000000000000000000e17929…, 1764015 bytes
2024-07-12T19:56:36.383Z INFO    plugin-bookkeeper: account wallet not found, adding
2024-07-12T20:07:10.788Z plugin-trustedcoin returning block 851877, 00000000000000000002d3e0ed…, 1589044 bytes
2024-07-12T20:12:28.073Z plugin-trustedcoin estimatefees error: https://blockstream.info/api error: 502 Bad Gateway
/home/cln/.lightning/plugins/trustedcoin error: bad response to estimatefees.feerate_floor (Not a u32?), response was null
2024-07-12T20:12:28.074Z **BROKEN** lightningd: /home/cln/.lightning/plugins/trustedcoin error: bad response to estimatefees.feerate_floor (Not a u32?), response was null
lightningd: FATAL SIGNAL 6 (version v24.05)
0x5fa5eac0011b ???
	???:0
0x5fa5eac001a3 ???
	???:0
0x7e73702bafea ???
	???:0
2024-07-12T20:12:28.076Z **BROKEN** lightningd: FATAL SIGNAL 6 (version v24.05)
2024-07-12T20:12:28.076Z **BROKEN** lightningd: backtrace: (null):0 ((null)) 0x5fa5eac00163
2024-07-12T20:12:28.076Z **BROKEN** lightningd: backtrace: (null):0 ((null)) 0x5fa5eac001a3
2024-07-12T20:12:28.076Z **BROKEN** lightningd: backtrace: (null):0 ((null)) 0x7e73702bafea
Log dumped in crash.log.20240712201228
$