solves #issue82 by fixing the comparison between a Series and a list #83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #issue82.
A previous bugfix around >>combined_df = combined_df[combined_df['category'] not in ['?', 'nan']] << was wrong in the sense that it was trying to check if the entire combined_df['category'] Series is "not in" the list ['?', 'nan']. This boils down to a comparison between a Series and a list, which led to a ValueError: The truth value of a Series is ambiguous. Use a.empty, a.bool(), a.item(), a.any() or a.all().
Description of changes
To properly filter the DataFrame by checking if each element in the category column is not in the list ['?', 'nan'], now the .isin() method is used in combination with the negation operator '~'
Includes