Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store toolbar state in localStorage #3835

Open
5e-Cleric opened this issue Oct 17, 2024 · 6 comments
Open

Store toolbar state in localStorage #3835

5e-Cleric opened this issue Oct 17, 2024 · 6 comments
Labels
feature tweak Small, non-breaking change UI/UX User Interface, user experience

Comments

@5e-Cleric
Copy link
Member

Both visibility and zoom state should be saved in localstorage with the id of the brew, to guarrantee a better UX, if a user does not want to have the toolbar there all the time, it should stay hidden between reloads, and same goes for the zoom level.

@5e-Cleric 5e-Cleric added feature tweak Small, non-breaking change UI/UX User Interface, user experience labels Oct 17, 2024
@Gazook89
Copy link
Collaborator

How many different brew ids should be in there?

@calculuschild
Copy link
Member

Why not just a universal setting instead of per brew?

@5e-Cleric
Copy link
Member Author

I was thinking you may want to see a different zoom and page layout depending on the brew, but perhaps you're right, one universal setting is good enough.

@Gazook89
Copy link
Collaborator

How about this: save the current setting in localStorage, not as brew specific. But if a new (not just /new but just a different) brew is opened, it is reset to the defaults.

So this means that if you hit reload on the page, the view settings are preserved. But if you decide to view/edit/create a new brew, it goes back to the default.

@calculuschild
Copy link
Member

calculuschild commented Oct 19, 2024

How about this: save the current setting in localStorage, not as brew specific. But if a new (not just /new but just a different) brew is opened, it is reset to the defaults.

So this means that if you hit reload on the page, the view settings are preserved. But if you decide to view/edit/create a new brew, it goes back to the default.

This restriction sounds like it defeats the purpose of the PR if it disappears every time you change pages. How often are users just hitting reload on the same page without visiting another brew in between?

@5e-Cleric
Copy link
Member Author

This restriction sounds like it defeats the purpose of the PR if it disappears every time you change pages.

I agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature tweak Small, non-breaking change UI/UX User Interface, user experience
Projects
None yet
Development

No branches or pull requests

3 participants