Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue 3718 by bounds checking prerender. #3891

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Fix Issue 3718 by bounds checking prerender. #3891

merged 1 commit into from
Nov 12, 2024

Conversation

dbolack-ab
Copy link
Collaborator

@dbolack-ab dbolack-ab commented Nov 11, 2024 •
edited by calculuschild
Loading

Description

Add bounds-checking to prerender to prevent attempting to create pages past the current end of document.

Related Issues or Discussions

QA Instructions, Screenshots, Recordings

  • Start with a new document
  • Insert several \page entries
  • Ensure the cursor is not on the first Brew page.
  • Past over the full document with a single page text
  • Verify the correct number of pages and none list undefined as the sole content.

@calculuschild calculuschild merged commit e006826 into naturalcrit:master Nov 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
@calculuschild's backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undefined pages when pasting text
3 participants
@dbolack-ab @calculuschild @dbolacksn