Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brewrenderer cleanup #3693

Open
5e-Cleric opened this issue Aug 30, 2024 · 2 comments
Open

brewrenderer cleanup #3693

5e-Cleric opened this issue Aug 30, 2024 · 2 comments
Labels
cleanup Cleaning up code for legibility, style, ease-of-use, etc.

Comments

@5e-Cleric
Copy link
Member

I found this accidentally while fixing a toolbar issue.

image

We define the page height arbitrarily in brewRenderer to use to calculate scrolls and stuff. I know the function still works, but i assume this code could be cleaner.

In addition, this code calculates the height to establish in the brewRenderer element:

image

image

However, A height of 100vh, works just fine, given other adjustments that make sense to have the toolbar there.

I preferred to make an issue for this rather than cluttering the gitter chat.

@5e-Cleric 5e-Cleric added the cleanup Cleaning up code for legibility, style, ease-of-use, etc. label Aug 30, 2024
@5e-Cleric
Copy link
Member Author

To clarify, these features were made 8 years ago, viewport units did not exist.

@5e-Cleric
Copy link
Member Author

will be fixed by #3694

@5e-Cleric 5e-Cleric linked a pull request Sep 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Cleaning up code for legibility, style, ease-of-use, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant