Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some latin accents #3646

Closed
wants to merge 2 commits into from
Closed

Conversation

MiniX16
Copy link

@MiniX16 MiniX16 commented Aug 18, 2024

This PR resolves #3638.

Added some latin accents to the Mr Eaves Small Caps font. Here the comparison, before:

image

And after:

image

@5e-Cleric
Copy link
Member

Finally my character Ágata will have their name correctly displayed

@5e-Cleric 5e-Cleric requested a review from G-Ambatte August 18, 2024 15:58
@5e-Cleric 5e-Cleric added UI/UX User Interface, user experience Approved Has been discussed and an approach is agreed upon labels Aug 18, 2024
@G-Ambatte
Copy link
Collaborator

Can we get a reproduction brew, or source code for one? Sorry, I don't know how to create those characters on my keyboard.

@MiniX16
Copy link
Author

MiniX16 commented Aug 19, 2024

@G-Ambatte here you have:

# aáà AÁÀ

# eéè EÉÈ

# iíì IÍÌ

# oóò OÓÒ

# uúù UÚÙ

Is this what you asked for?

@5e-Cleric
Copy link
Member

Actually, please test with this:

# Character test

::

Basic Latin 
:

# ! " # $ % & ' ( ) * + , - . / 0 1 2 3 4 5 6 7 8 9 : ; < = > ? @ A B C D E F G H I J K L M N O P Q R S T U V W X Y Z [ \ ] ^ _ ` a b c d e f g h i j k l m n o p q r s t u v w x y z { | } ~

::

Latin-1 Supplement 
:

# ¡ ¢ £ ¤ ¥ ¦ § ¨ © ª « ¬ ­ ® ¯ ° ± ² ³ ´ µ ¶ · ¸ ¹ º » ¼ ½ ¾ ¿ À Á Â Ã Ä Å Æ Ç È É Ê Ë Ì Í Î Ï Ð Ñ Ò Ó Ô Õ Ö × Ø Ù Ú Û Ü Ý Þ ß à á â ã ä å æ ç è é ê ë ì í î ï ð ñ ò ó ô õ ö ÷ ø ù ú û ü ý þ ÿ

We don't need them all to exist, but Ñ would be nice too.

@MiniX16
Copy link
Author

MiniX16 commented Aug 19, 2024

Ohh didn't think about the Ñ. I'll add it. Also the Ü

@MiniX16
Copy link
Author

MiniX16 commented Aug 19, 2024

Here all the different symbols I added:

Before:

image

After:

image

@5e-Cleric
Copy link
Member

Please show all the characters i sent

@MiniX16
Copy link
Author

MiniX16 commented Aug 20, 2024

Ohh sorry, here you have:

image

I think only the "ß" is wrong (printed as "S") but I don't think I can do it myself (since every change I made was a copy-paste from other glyph and that would be a make from scratch job).

@calculuschild calculuschild temporarily deployed to homebrewery-pr-3646 August 20, 2024 17:44 Inactive
@calculuschild
Copy link
Member

calculuschild commented Aug 20, 2024

Sent out a test deployment for this https://homebrewery-pr-3646.herokuapp.com/.

Should help for getting a side-by-side comparison with longer strings, though from the screenshots it looks ok.
Can we just check that spacing between characters and alignment is untouched? I.e. we should be able to superimpose a screenshot from before and after (using a title that has accent markers) and show that everything lines up exactly, minus the accent mark.

@MiniX16 What software did you use to add the missing glyphs, if I might ask?

@5e-Cleric
Copy link
Member

Also, | appears to be the glyph for 1 for some reason, but that is not a big issue. I can fix the two characters if it is important, should be easy with Glyphr Studio 2

@calculuschild
Copy link
Member

calculuschild commented Aug 20, 2024

Mmmmm.... letter alignment and spacings appear to have been corrupted with this change. Especially noticeable on lowercase j. This will need to be redone.

See this video where I swap between the live version and the PR deployment.

Recording.2024-08-20.174055.mp4

@calculuschild
Copy link
Member

Also, | appears to be the glyph for 1 for some reason, but that is not a big issue. I can fix the two characters if it is important, should be easy with Glyphr Studio 2

It's different from the actual 1; might actually be a lowercase L? Might as well change it if we are remaking the font anyway. Our font is based in Mrs Eaves, which does use just a straight line.

image

@calculuschild calculuschild added the 🔍 R3 - Reviewed - Awaiting Fixes 🔧 PR is okayed but needs fixes before merging label Aug 20, 2024
@MiniX16
Copy link
Author

MiniX16 commented Aug 21, 2024

@MiniX16 What software did you use to add the missing glyphs, if I might ask?

I used birdFont (didn't find a different one free).

Mmmmm.... letter alignment and spacings appear to have been corrupted with this change. Especially noticeable on lowercase j. This will need to be redone.

Offf... didn't realized about that. I can try to redo it with Glyphr Studio 2 as @5e-Cleric said.

EDIT: Also tried FontForge but not working idk why.

@5e-Cleric
Copy link
Member

If you feel like it is problematic, i can jump in.

@MiniX16
Copy link
Author

MiniX16 commented Aug 21, 2024

I'll do one last try and if I don't succeed it's yours.

Never thought that modifying a font could be that messy.

@MiniX16 MiniX16 closed this Aug 21, 2024
@MiniX16 MiniX16 deleted the addLatinAccents branch August 21, 2024 15:44
@MiniX16
Copy link
Author

MiniX16 commented Aug 21, 2024

Oops when deleting the branch, the PR closed, didn't thought that would happen. Anyways, I tried again with Glyphr Studio 2 and same problem, (even worse) so maybe @5e-Cleric you can take it from here hehe.

@5e-Cleric
Copy link
Member

Hm, not sure how could that happen, i'll try.

@5e-Cleric
Copy link
Member

Simply changing the format to woff to work in glyphr already produces changes for some reason.

@MiniX16
Copy link
Author

MiniX16 commented Aug 22, 2024

Yeah that's what a thougth, also all woff2 editors are not free. I've only found FontForge if you want to try but when I was trying for no reason when modifying one "A" (for example) all "A" were modified.

@MiniX16
Copy link
Author

MiniX16 commented Aug 22, 2024

I just tried doing it with FontForge (since a random guy at reddit told me how to fix my last problem with FontForge and finally modify only one glyph at the same time) but same problem. Here there wasn't any conversion, the file started as .woff2 and ended up being a .woff2. Asked again at reddit but the only solution I see is adjust every character by hand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Has been discussed and an approach is agreed upon 🔍 R3 - Reviewed - Awaiting Fixes 🔧 PR is okayed but needs fixes before merging UI/UX User Interface, user experience
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Table of contents doesn't print accents in uppercase letters at the title
4 participants