-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify Homebrewery strings to allow alternate languages #2624
Comments
If this feature is approved, i will take responsability for the Spanish (es-es) and Catalan (ca-es) translation, for the forseeable future. i'm guessing once more than one language is set up, adding extra languages should be a minor tweak, just another json file maybe. |
Issue #116 might be a problem |
Yes, but i would argue that the fact that we translate the UI might make users try to homebrew in their native language, which will get to #116 blocking their progress, let's make this and then we can look into fixing those fonts, yeah? |
Yep, one Also, the brew-document lang doesn't have to be the same as the UI lang. But we know this. Also, see #1343 for related hmm .. if someone set their brew |
Snippet names is UI, but content is brew, if a user sets UI lang to At least that's what makes sense to me. Also, we should include language in User settings #1908, do we know when will that be merged? so we have a time limit. Both are right now in hands of @jeddai i believe, so we need their take on this. |
Trying to jump start this issue, or at least get someone else's view on how I could start making progress towards the defined goal. I believe the original idea was to have a YAML file for every desired UI language, each storing string references and their content in that specific language. We should come up with a naming convention for strings, to achieve consistency and avoid chaos. Any ideas on that front? This is the first draft for such a YAML file. |
Having defined names for specific instances of strings is one approach. Another approach is to skip the naming entirely, and have the base English strings be the lookup keys, This approach has pros and cons. (Technically, it's still a key:value pairing, it's just that the keys are things like "are you sure you want to log off?" instead of LogOutConfirmQuery). |
I didn't get that impression. It could instead be one file, maybe like:
|
There would be little difference, i guess your approach is easier to implement and smaller in size, let's do that |
Using ChatGPT to do the bulk of the work, and the first draft of the localization file, i got a nice starting point: |
I follow this issue, as i would love to translate to French |
@lucastucious and others, you can follow the instructions given in this document: |
Your idea:
Modifying Homebrewery to use a file containing all of the text strings presented to the end user will allow the creation of string files for alternate languages, and the site can then be switched between translations as desired by the user.
The text was updated successfully, but these errors were encountered: