You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Astro v4.0.8
Node v18.18.0
System Linux (x64)
Package Manager npm
Output static
Adapter none
Integrations astro-icon
If this issue only occurs in one browser, which browser is a problem?
No response
Describe the Bug
When using a local SVG file (containing comments <!-- -->) from the icons folder, the rendered HTML does not contain the comments, although the SVGO plugin removeComments is disabled in the config file:
Comments should be preserved in the final output, since some icons (e.g. Font Awesome) require the CC BY 4.0 license notice (https://fontawesome.com/license/free)
I dug into this a little bit, and it looks like we are passing the svgoOptions through. It seems like Iconify's importDirectory utility has already stripped the comments before we even have access to them.
What version of
astro-icon
are you using?v1.0.1
Astro Info
If this issue only occurs in one browser, which browser is a problem?
No response
Describe the Bug
When using a local SVG file (containing comments
<!-- -->
) from theicons
folder, the rendered HTML does not contain the comments, although the SVGO pluginremoveComments
is disabled in the config file:What's the expected result?
Comments should be preserved in the final output, since some icons (e.g. Font Awesome) require the CC BY 4.0 license notice (https://fontawesome.com/license/free)
Link to Minimal Reproducible Example
https://stackblitz.com/edit/github-aqxtyy?file=astro.config.mjs
The text was updated successfully, but these errors were encountered: