Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support certificate-per-domain #236

Closed
zakeryooo opened this issue Dec 28, 2021 · 8 comments · May be fixed by #301
Closed

Support certificate-per-domain #236

zakeryooo opened this issue Dec 28, 2021 · 8 comments · May be fixed by #301
Labels
closed-stale enhancement New feature or request help wanted I would accept a PR to help complete this issue stale

Comments

@zakeryooo
Copy link

Hi,

I'm using LettuceEncrypt in a YARP project, the reverse proxy sends requests from https://domain1.com and https://domain2.com to separate web apps each using their own kestrel instances (localhost:5001, localhost:5005).

Everything is working OK, but LettuceEncrypt is generating a single SSL certificate which covers both domains and instead I'm wanting it to generate a separate certificate for each domain, it's configured like this at the moment:

"DomainNames": [ "domain1.com", "domain2.com" ],

Is there a way to generate a certificate-per-domain instead of a single certificate for all domains?

Thanks

@natemcmaster
Copy link
Owner

This is not currently possible.

@zakeryooo
Copy link
Author

Ok thanks, do you know if anyone else is working on this? I haven't had chance to look at the code yet be aware of how much work would be needed to add this, but if I get time to add it is it the sort of thing you'd accept a pull request for?

@natemcmaster
Copy link
Owner

I doubt anyone is working on this. The project is currently in maintenance mode (#189) so I'm not actively developing it, and there are aren't any other active contributors on this project. I'm not opposed to adding features, but even if someone else is implementing, it takes time for me to review, provide meaningful feedback, and then support the change for years to come.

I am not saying this to discourage you. I'm open to having other active contributors join this project who can pick up feature work and also provide support and bug fixes, but so long as I'm the only maintainer, I don't plan to accept new features.

@benschop-it
Copy link

I am also very much interested in certificate-per-domain functionality, and I'd be happy to work with someone (zakeryooo?) on this.

@natemcmaster natemcmaster changed the title Is certificate-per-domain possible? [Question] Support certificate-per-domain Jan 16, 2022
@natemcmaster natemcmaster added enhancement New feature or request help wanted I would accept a PR to help complete this issue and removed question labels Jan 16, 2022
@natemcmaster
Copy link
Owner

Marking as help wanted. Let me know if you're interested in contributing this feature request.

@benschop-it
Copy link

benschop-it commented Feb 21, 2022

I have implemented this feature in my fork at https://github.com/benschop-it/LettuceEncrypt-Benschop-IT.
This makes it possible to create a certificate per set of domains.
Some extra tests still need to be added.
Feel free to comment.

@github-actions
Copy link

This issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please comment if you believe this should remain open, otherwise it will be closed in 14 days. Thank you for your contributions to this project.

@github-actions github-actions bot added the stale label Feb 23, 2023
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Closing due to inactivity.
If you are looking at this issue in the future and think it should be reopened, please make a commented here and mention natemcmaster so he sees the notification.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-stale enhancement New feature or request help wanted I would accept a PR to help complete this issue stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants