Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of missing variables #16

Open
prkunz opened this issue Feb 10, 2022 · 0 comments
Open

Improve handling of missing variables #16

prkunz opened this issue Feb 10, 2022 · 0 comments

Comments

@prkunz
Copy link
Collaborator

prkunz commented Feb 10, 2022

The current behavior is typically a segfault :face_palm:

There are two things we can do better:

  1. Detect the missing variable response when unpacking messages from sim: "The message returned for the non-existent variable will have a type of 24 and it's value will be the string 'BAD_REF'."
  2. Ask Trick if variables exist using the var_exists command

I think we'll want to do both, since the latter will be the only way to check if variables used in commands exist.

When a variable is missing, the easiest response is to exit the app.

However we could do better and just turn off individual messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant