You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Consider reworking ARGCHECK. Although it reduces repeated lines in code, it does "hide" a return within the macro and isn't really the simplest macro when combined with OS_CHECK_STRING or similar. Note it works... it's just not a trivial macro so ends up triggering coding standard warnings.
Describe the solution you'd like
Although we did just disable the warning in nasa/cFS#561, it's a warning that would be good to apply to non-macro code at least. Really this issue trades macro complexity with function complexity where there is no real right answer in my mind. The point if this issue is to at least document this for future consideration, not necessarily back out the changes.
Describe alternatives you've considered
Leave as-is
Additional context
None
Requester Info
Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
Consider reworking ARGCHECK. Although it reduces repeated lines in code, it does "hide" a return within the macro and isn't really the simplest macro when combined with OS_CHECK_STRING or similar. Note it works... it's just not a trivial macro so ends up triggering coding standard warnings.
Describe the solution you'd like
Although we did just disable the warning in nasa/cFS#561, it's a warning that would be good to apply to non-macro code at least. Really this issue trades macro complexity with function complexity where there is no real right answer in my mind. The point if this issue is to at least document this for future consideration, not necessarily back out the changes.
Describe alternatives you've considered
Leave as-is
Additional context
None
Requester Info
Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered: