Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Manager Update #7948

Open
WavesJ99 opened this issue Dec 9, 2024 · 0 comments
Open

Notification Manager Update #7948

WavesJ99 opened this issue Dec 9, 2024 · 0 comments

Comments

@WavesJ99
Copy link

WavesJ99 commented Dec 9, 2024

Overview
This PR introduces a significant architectural improvement to OpenMCT's notification system by introducing a dedicated NotificationManager class and enhancing the NotificationAPI. The changes provide a more robust and flexible notification system while maintaining backward compatibility.

Key Changes
Introduces a new NotificationManager class to handle core notification logic
Adds support for notification grouping to manage related notifications
Implements a comprehensive priority system considering multiple factors
Adds support for custom notification categories
Introduces persistent notifications that resist auto-dismissal
Improves notification lifecycle management

Benefits
Better separation of concerns between API interface and notification management
Enhanced developer experience with more powerful notification APIs
Improved organization of notifications through grouping capability
More flexible notification categorization and prioritization
Better management of system-critical notifications through persistence

Implementation Details
The implementation splits the existing notification logic into two main components:
NotificationManager: Handles core notification management, grouping, and prioritization
Enhanced NotificationAPI: Provides an improved interface while maintaining backward compatibility

Testing
Added comprehensive test coverage for new functionality including:
NotificationManager unit tests
Enhanced NotificationAPI tests
Group management tests
Category and priority system tests

The changes are fully backward compatible and require no changes to existing notification usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant