Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile to install python libraries in two steps, needed to run then needed for dev work #157

Open
the-other-james opened this issue Oct 4, 2024 · 1 comment

Comments

@the-other-james
Copy link
Contributor

No description provided.

@dragonejt
Copy link
Contributor

dragonejt commented Nov 26, 2024

Per the comment from @asgibson in #156 :

environment_dev.yml includes Black and Pylint. Did we want those required for the container?

If the dockerfile is just used for running OnAIR in production, I don't think we need black and pylint (the dev dependencies) to be installed in the docker image. I can change the Dockerfile to just reference the non-dev dependencies. The usual usage of black and pylint is as packages within a conda environment or python virtual environment. Docker containers are usually meant to just have the necessary dependencies to actually run the software.

If we do want to keep dev dependencies in the Dockerfile, I can also so what the original issue asks. Are we now installing based off of the requirements-*.txt files and no longer from the environment_*.yml ones?

Also, is it worth adding a GitHub action to build the docker image and make sure that works on each PR/push? That doesn't seem to exist currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants