You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
environment_dev.yml includes Black and Pylint. Did we want those required for the container?
If the dockerfile is just used for running OnAIR in production, I don't think we need black and pylint (the dev dependencies) to be installed in the docker image. I can change the Dockerfile to just reference the non-dev dependencies. The usual usage of black and pylint is as packages within a conda environment or python virtual environment. Docker containers are usually meant to just have the necessary dependencies to actually run the software.
If we do want to keep dev dependencies in the Dockerfile, I can also so what the original issue asks. Are we now installing based off of the requirements-*.txt files and no longer from the environment_*.yml ones?
Also, is it worth adding a GitHub action to build the docker image and make sure that works on each PR/push? That doesn't seem to exist currently.
No description provided.
The text was updated successfully, but these errors were encountered: