Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional dependencies discussion: numba, py-triangle #105

Open
github-actions bot opened this issue Jan 20, 2024 · 4 comments
Open

Optional dependencies discussion: numba, py-triangle #105

github-actions bot opened this issue Jan 20, 2024 · 4 comments
Assignees
Labels

Comments

@github-actions
Copy link

The file setup.cfg was modified in napari/napari. This might mean the conda-recipe in
napari/packaging needs adjusting! Please check!

Calculated diff:

diff --git a/setup.cfg b/setup.cfg
index 6560f1e6..d2ac6e45 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -114,7 +114,7 @@ all =
     napari-plugin-manager >=0.1.0a1, <0.2.0
 # optional (i.e. opt-in) packages, see https://github.com/napari/napari/pull/3867#discussion_r864354854
 optional =
-    triangle
+    triangle ; platform_machine != 'arm64'  # no wheels
     numba>=0.57.1
 testing =
     babel>=2.9.0

cc @jaimergp

@jaimergp
Copy link
Collaborator

We are not including triangle (in conda-forge, py-triangle) in the conda package, so I think I won't add this. That said, the conda-forge package is indeed built for osx-arm64. Any thoughts here @Czaki?

@jaimergp jaimergp changed the title setup.cfg was updated (2024-01-20) Optional dependencies discussion: numba, py-triangle Feb 1, 2024
@jaimergp
Copy link
Collaborator

jaimergp commented Feb 1, 2024

For now I have added them to the meta.yaml file, but commented out. At some point we can resume the discussion if we want to consider a policy change for 0.5.0.

@jaimergp jaimergp added the bundle label Feb 1, 2024
@psobolewskiPhD
Copy link
Member

My vote would be that the conda-forge install be the fully monty everything working tiptop and easiest.
triangle has the licensing issue for the bundle but here for a dependency it should be ok?
cc: @jni

@jni
Copy link
Member

jni commented Feb 12, 2024

Well, currently I am battling segfaults with the triangle macOS package from conda-forge, so I'm not super convinced that it should be our default...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants