Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show errors from commit failure #48

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Show errors from commit failure #48

wants to merge 1 commit into from

Conversation

yzguy
Copy link

@yzguy yzguy commented Jun 21, 2023 •
edited
Loading

Fixes #47

Capture the errors from Netmiko and show them to the user

Before:

TASK [Apply Configuration] **********************************************
fatal: [dev]: FAILED! => changed=false 
  msg: 'cannot install config: Failed to commit config on the device'

After:

TASK [Apply Configuration] ************************************************
fatal: [dev]: FAILED! => changed=false 
  msg: |-
    cannot install config:
  
    Commit failed with following errors:
  
    commit
    [ interfaces l2tpv3 l2tpeth1 address 192.168.1/30 ]
    Error: 192.168.1/30 is not a valid IP host
  
  
  
    [ interfaces l2tpv3 l2tpeth1 address 192.168.1/30 ]
    Invalid value
  
    [[interfaces l2tpv3 l2tpeth1]] failed
    Commit failed
    [edit]

@yzguy yzguy changed the title display errors from failed commits Show errors from commit failure Jun 21, 2023
@yzguy yzguy mentioned this pull request Jun 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors from failed commits are not returned
1 participant
@yzguy