New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors from failed commits are not returned #47

Open

yzguy opened this issue Jun 21, 2023 · 0 comments · May be fixed by #48

yzguy commented Jun 21, 2023 •

edited

Loading

When applying a commit that ultimately fails the errors are not shown to the user, looking at Netmiko it does capture these errors and passes it back when a ValueError exception is raised https://github.com/ktbyers/netmiko/blob/5f9eaa9e54401a758375574c656655e44bee3746/netmiko/vyos/vyos_ssh.py#L94-L95

napalm-vyos just catches the ValueError and raises a CommitError with it's own message.

TASK [Apply Configuration] **********************************************
fatal: [dev]: FAILED! => changed=false 
  msg: 'cannot install config: Failed to commit config on the device'

The text was updated successfully, but these errors were encountered:

yzguy linked a pull request

that will close this issue

Show errors from commit failure #48

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment