Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing "miniupnpc/" include paths #180

Open
cassiniNMC opened this issue Sep 21, 2014 · 8 comments
Open

Missing "miniupnpc/" include paths #180

cassiniNMC opened this issue Sep 21, 2014 · 8 comments

Comments

@cassiniNMC
Copy link

The absence of "miniupnpc/" of the #include lines in net.cpp is incompatible with some of the package managers.

@phelixbtc
Copy link
Contributor

If I understand you correctly you suggest that we should (re)add the path "minipunpnc/" in the includes? I will edit your post a little to clarify.
On windows that caused an issue because the folder is actually called "miniupnpc-1.8/". The object files for miniupnpc should go into a SUBfolder "miniupnpc" within the folder "miniupnpc-1.8/".
The patch for EasyWinBuilder is already available from Bitcoin. If it helps for MAC this change is ok with Windows I guess.
@domob1812 Maybe someone from the Linux side could comment.

@phelixbtc phelixbtc changed the title net.cpp port from Bitcoin is out-of-date Missing "miniupnpc/" include paths Sep 21, 2014
@pmconrad
Copy link

Linux distributions vary in miniupnp include paths. In my packages I have solved the problem by invoking qmake with "INCLUDEPATH=/usr/include/miniupnpc" and "make -C src OPENSSL_INCLUDE_PATH=/usr/include/miniupnpc" for the daemon.

@domob1812
Copy link
Contributor

@phelixbtc Namecoin failed to build for me with UPNP enabled (Debian Wheezy) after your commit. Since I don't want UPNP anyway, I did just disable it so far, which works well for me. I don't know what exactly the problem is or how to fix it correctly (never tried to find it out due to lack of interest in UPNP).

@phelixbtc
Copy link
Contributor

@pmconrad would it be a problem for you if we would add the paths again?

@pmconrad
Copy link

If anything breaks I'll find a workaround...

@phelixbtc
Copy link
Contributor

@cassiniNMC In EasyWinBuilder I would have to hack around (changing the source file, copying object files or renaming the miniupnpc folder). I wonder how a clean solution to this could look like? Anyway for now I would prefer #ifdef APPLE and leave the other systems alone.

@Ademan
Copy link

Ademan commented Nov 11, 2014

28e7e65 breaks my build on Ubuntu 14.04 as well. I believe rather than explicitly breaking the build on Linux (and OSX?) systems, hacking around EasyWinBuilder's issues is the correct solution. Technically this a hack anyways since the correct include is #include <miniupnpc/*.h> anyways. I'll see if I can help at all on that front.

@phelixbtc
Copy link
Contributor

OK then. #196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants