Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update namecoin electrums #994

Merged
merged 5 commits into from
Mar 14, 2024
Merged

update namecoin electrums #994

merged 5 commits into from
Mar 14, 2024

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Mar 8, 2024

@smk762 smk762 requested review from gcharang and cipig March 8, 2024 05:16
@cipig
Copy link
Member

cipig commented Mar 8, 2024

has conflicts, likely because i added some NMC electrums in this commit too: 3939cae
the dotbit.zone electrums have a self signed cert... afaik those don't work with WSS
see https://electrumx3.nmc.dotbit.zone:50004
image

@smk762
Copy link
Collaborator Author

smk762 commented Mar 8, 2024

cc: @gits7r

@cipig
Copy link
Member

cipig commented Mar 8, 2024

unfortunately, the SSL ports of dotbit.zone don't work either because of the self signed certs
coins::utxo::rpc_clients:2666] ERROR "electrumx1.nmc.dotbit.zone:50002" error Custom { kind: InvalidData, error: InvalidCertificateData("invalid peer certificate: UnsupportedCertVersion") }
it would only work if they are signed by an own CA and by using the param disable_cert_verification
but it's easier to get real certs from letsencrypt for free and use certbot to create/renew them

@gits7r
Copy link

gits7r commented Mar 9, 2024

The servers were set-up using the standard ElectrumX (server implementation) manual. Electrum wallet uses a cache that stores the certificate of each server after first connect, and it will not connect to that server any more if server changes its certificate unless it is expired or manually deleted by the user from Electrum wallet cache / persistent data. It's called TOFS (trust on first seen). Is it critical for you for the certificates to be signed by a trusted CA?

@cipig
Copy link
Member

cipig commented Mar 9, 2024

Is it critical for you for the certificates to be signed by a trusted CA?

We can't connect to SSL or WSS if the cert is self signed. That means that the Web version of Komodo Wallet will not have NMC at all and Desktop/Mobile can only use the TCP ports.

@gits7r
Copy link

gits7r commented Mar 13, 2024

All your concerns have been fixed at least for the *.dotbit.zone servers that also run under raw IP addresses and .onion hostnames. They now use CA signed SSL certificates, I hope this will not be a trouble for electrum wallet users that have connected using the self-signed one since the certificate change. It's a little bit complicated because LE uses a validity period of 90 days, and for automatic renewals it's more complicated than for an apache web server, especially if the ports 80 and 443 are blocked by something else... but still , I hope this helps.

@cipig cipig merged commit 93ce012 into master Mar 14, 2024
@cipig cipig deleted the update/namecoin-electrums branch March 14, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ElectrumX server connection issues
3 participants