Migrate to phpspec/prophecy-phpunit #178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianbergmann/phpunit#5033 changed phpunit to no longer depend on phpspec/prophecy. This results in the need to add a development dependency for phpspec/prophecy. Doing so results in a warning, since PHPUnit\Framework\TestCase::prophesize() is deprecated and will be removed in PHPUnit 10. Let's use the trait provided by phpspec/prophecy-phpunit instead. * Fixes myclabs#177
|
Note that phpspec/prophecy-phpunit v2.0.0 requires php ^7.3. One alternative here would be to just require phpspec/prophecy instead. But then, such support will be dropped for phpunit 10. Thoughts? |
|
Thanks for the PR! I would be fine dropping support for older PHP versions and require PHP 7.4+, would that work? |
|
It works for me, but then, would it cause any trouble for other users? If in doubt we can always just require phpspec/prophecy and delay the decision! |
Ah sorry I missed that, yeah that sounds great! |
This reverts commit e03ad06. Supporting phpspec/prophecy-phpunit at this point, would require dropping php <= 7.2 support. We can re-visit this matter once we start supporting phpunit 10.
athos-ribeiro
force-pushed
the
use-prophecy-phpunit
branch
from
d63f3cc
to
b95de66
Compare
|
I lowered the dependency version to one that should accept php 7.1 now :) |
|
Done in #183 |
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sebastianbergmann/phpunit#5033 changed phpunit
to no longer depend on phpspec/prophecy. This results in the need to add
a development dependency for phpspec/prophecy. Doing so results in a
warning, since PHPUnit\Framework\TestCase::prophesize() is deprecated
and will be removed in PHPUnit 10. Let's use the trait provided by
phpspec/prophecy-phpunit instead.