Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving to bzlmod ? #161

Closed
oh-tarnished opened this issue Aug 9, 2023 · 7 comments
Closed

Moving to bzlmod ? #161

oh-tarnished opened this issue Aug 9, 2023 · 7 comments

Comments

@oh-tarnished
Copy link

Hey @mvukov , Any plans to move to bzlmod ?

@mvukov
Copy link
Owner

mvukov commented Aug 10, 2023

Hello, I don't have plans to support bzlmod short-term. IMO, it's a good future-proof initiative.

@oh-tarnished
Copy link
Author

I was thinking of making a PR. would it be okay ? I think by end of this lifecycle of bazel 6.

@mvukov
Copy link
Owner

mvukov commented Aug 10, 2023

👍 Sounds good.

@oh-tarnished
Copy link
Author

oh-tarnished commented Aug 31, 2023

Hey Again,

Did you consider moving all the python deps to poetry project ? instead of pip ? I love how poetry handles the dependencies and cross-compile your code.

Someone already made a bazel rules for that we are using it at our company. rules_poetry

suggestion to move all the python deps to poetry .. which would solve the cross compilation for python deps

Pull Request #173

@mvukov
Copy link
Owner

mvukov commented Sep 1, 2023

I am thinking to use poetry as a dep resolver instead of pip-compile. pip-compile cannot resolve deps for another platform, but poetry can -- thinking here about arm64. I have never used rules_poetry. Didn't look into the details, but, not declaring each dep as a separate workspace (but having all deps in a single workspace) doesn't allow for incremental downloads. This could be a serious issue once you have a lot of deps. I've used rules_python when it didn't have incremental downloads and it wasn't so convenient.

How does poetry solve cross-compilation issues? Does it use Bazel-provided cc toolchain(s)?

@oh-tarnished
Copy link
Author

Well rules_poetry depends on poetry.lock file which has all the supported wheel files to compile. if for instance the wheel file doesn't exist for a particular architecture then it throws an error out. saying unsupported architecture based. how pip vendors each library for single architecture .... poetry does it for multiple and it doesn't use any cc-toolchains.

@mvukov
Copy link
Owner

mvukov commented Sep 23, 2023

IMO, it's sufficient to track #173.

@mvukov mvukov closed this as completed Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants