Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soprano missing many isotopes #51

Open
joelvdavies opened this issue Feb 10, 2023 · 2 comments
Open

soprano missing many isotopes #51

joelvdavies opened this issue Feb 10, 2023 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@joelvdavies
Copy link
Contributor

For silicon for instance, only have 29Si, which by the looks of it isn't the most abundant (28Si). These also have different spins so (1/2 vs 0) so muspinsim may behave in an unexpected way.

@joelvdavies joelvdavies added bug Something isn't working enhancement New feature or request labels Feb 10, 2023
This was referenced Feb 10, 2023
@joelvdavies
Copy link
Contributor Author

As a further thing to be careful of, currently 19F is mislabelled as a spin 1/2. This is fine when not including quadrupole moments as it will behave as expected, but since soprano only currently includes NMR active nuclei, since the electric quadrupole moment tensor of a spin 1/2 nuclei is 0, the quadrupolar moment its actually referring to is an excited state with spin 5/2. So in effect, any quadrupole interactions for 19F will be calculated incorrectly. This is currently avoided due to raising an error for such spin 1/2 nuclei but if soprano were to label it correctly then 19F would refer to the excited state in muspinsim instead of the ground state which may be unexpected.

@joelvdavies
Copy link
Contributor Author

For future reference: There are issues over on mendeleev here: lmmentel/mendeleev#97 and lmmentel/mendeleev#100 for potentially improving mendeleev and using it in soparano.

The last time I heard from Kane he was unsure what approach to take between waiting for and fixing mendeleev vs creating their own package/updating soprano, I gave him my thoughts but haven't heard back since, it would be worth checking if its progressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant