Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Cached memory calculation #1591

Open
starinacool opened this issue Nov 8, 2023 · 4 comments
Open

Incorrect Cached memory calculation #1591

starinacool opened this issue Nov 8, 2023 · 4 comments
Labels
[component] plugins

Comments

@starinacool
Copy link
Contributor

We should not decrease cached memory by amount of shared memory.
We should exclude shared memory from apps memory.

https://github.com/munin-monitoring/munin/blob/16eff1e959e1ed3dbdb615c3834a2a596efebcc9/plugins/node.d.linux/memory#L304C80-L304C80
@steveschnepp
Copy link
Member

Thanks!

Do you have some documentation that shows our implementation is incorrect ?

@steveschnepp
Copy link
Member

You already replied in #1592 (comment) 👍

@kenyon kenyon mentioned this issue Nov 8, 2023
Open
@BETLOG
Copy link

BETLOG commented Nov 19, 2023

I was about to ask a similar question. Is this issue whats causing this slightly horrifying graph escalation?
2023-11-19--14-08-10_betlogbeast_memoryMuninmuninbetlogbeastmemoryGoogleChrome

@kenyon kenyon changed the title Incorect Cached memory calculation Incorrect Cached memory calculation Nov 19, 2023
@steveschnepp
Copy link
Member

No. that is CommittedAS which is increasing too much. And it seems to be due to some change between the kernel version 5.10 and 6.1, as a debian 11 to 12 upgrade shows it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[component] plugins
Milestone
No milestone
Development

No branches or pull requests
3 participants
@starinacool @steveschnepp @BETLOG