Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getWeaponNameFromID() returns duplicate ID's for 10/11 and 12/13 #514

Open
ArranTuna opened this issue Sep 20, 2018 · 3 comments · May be fixed by #3801
Open

getWeaponNameFromID() returns duplicate ID's for 10/11 and 12/13 #514

ArranTuna opened this issue Sep 20, 2018 · 3 comments · May be fixed by #3801
Labels
bug Something isn't working
Milestone
Backlog

Comments

@ArranTuna
Copy link
Collaborator

ArranTuna commented Sep 20, 2018 •
edited by qaisjp
Loading

Describe the bug
When i use getWeaponNameFromID(10) or getWeaponNameFromID(11) these always return "Dildo".

getWeaponNameFromID(10) It's the short dildo.

getWeaponNameFromID(11) It's the long dildo.

If I use this function getWeaponIDFromName(getWeaponNameFromID(11)) this will return 10.

To Reproduce
Executing client-side command: getWeaponNameFromID(10)
Command results: Dildo [string]
Executing client-side command: getWeaponNameFromID(11)
Command results: Dildo [string]
Executing client-side command: getWeaponNameFromID(12)
Command results: Vibrator [string]
Executing client-side command: getWeaponNameFromID(13)
Command results: Vibrator [string]

Weapons having duplicate names is not good.

Expected behavior
Should return a different name.

Screenshots
Unstated.

MTA Client (please complete the following information):
Unstated.

MTA Server (please complete the following information):
Unstated.

Additional context
From https://bugs.mtasa.com/view.php?id=7968
@ArranTuna ArranTuna added the bug Something isn't working label Sep 20, 2018
@qaisjp qaisjp added this to the Backlog milestone Sep 21, 2018
@Unde-R
Copy link
Contributor

Unde-R commented Aug 15, 2020 •
edited
Loading

@qaisjp Any idea for the new names? or We can keep them as above.

@qaisjp
Copy link
Contributor

qaisjp commented Aug 15, 2020

SA-MP names it as dildo, purple dildo, vibrator, silver vibrator. https://wiki.sa-mp.com/wiki/Weapons

I don't know if those are good names I'd have to look in-game.

According to that wiki page it's defined as WEAPON_DILDO and WEAPON_DILDO2 (similar for vibrator).

@Unde-R
Copy link
Contributor

Unde-R commented Aug 15, 2020

Yeah sure.

@Fernando-A-Rocha Fernando-A-Rocha linked a pull request Oct 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Fix Purple Dildo and Silver Vibrator weapon names Fernando-A-Rocha/mtasa-blue
3 participants
@ArranTuna @qaisjp @Unde-R