Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DashboardLayout] Modify the default AppBar branding link #4450

Open
ashishjaswal2002 opened this issue Nov 22, 2024 · 21 comments
Open

[DashboardLayout] Modify the default AppBar branding link #4450

ashishjaswal2002 opened this issue Nov 22, 2024 · 21 comments
Labels
component: layout This is the name of the generic UI component, not the React module! new feature New feature or request scope: toolpad-core Abbreviated to "core"

Comments

@ashishjaswal2002
Copy link

ashishjaswal2002 commented Nov 22, 2024

Steps to reproduce

Steps:

  1. Open this link to live example: (required)

Current behavior

I am using Dashboard Layout
i have an error when i click on the logo it is redirecting to the '/' layout
and if i add

it is giving me error of a descendant elements because is already defined with '/' route. What i want is that to change the '/' route inside a tag how to access this anchor tag so i can change the route.

As you can see the code i am accessing the classes of material ui so i can add my own style inside createTheme.

Please reply fast and i cannot provide the live link because it is against the company.

Expected behavior

import * as React from "react";
import PropTypes from "prop-types";
import { createTheme } from "@mui/material/styles";
import Box from "@mui/material/Box";
import { AppProvider } from "@toolpad/core/AppProvider";
import { DashboardLayout } from "@toolpad/core/DashboardLayout";
import { Outlet, useLocation, useNavigate } from "react-router-dom"; // Import Outlet to render nested routes
import DashboardIcon from "@mui/icons-material/Dashboard";
import GrassIcon from "@mui/icons-material/Grass";
import ImagesearchRollerIcon from "@mui/icons-material/ImagesearchRoller";
import { FolderIcon } from "lucide-react";
import PeopleOutlineIcon from "@mui/icons-material/PeopleOutline";
import TourIcon from "@mui/icons-material/Tour";
import logo from "../assets/Images/Logo.png";

import SupportAgentIcon from "@mui/icons-material/SupportAgent";
import NotificationsActiveIcon from "@mui/icons-material/NotificationsActive";
import Navbar from "../components/navbar/page";

const navigation = [
  {
    segment: "dashboard",
    title: "Dashboard",
    icon: <DashboardIcon />,
  },
  {
    segment: "ground-manager",
    title: "Ground Manager",
    icon: <GrassIcon />,
    children: [
      {
        segment: "view-grounds",
        title: "View Grounds",
        icon: <FolderIcon />,
      },
    ],
  },
  {
    segment: "banner-manager",
    title: "Banner Manager",
    icon: <ImagesearchRollerIcon />,
    children: [
      {
        segment: "add-banners",
        title: "Add New Banner",
        icon: <FolderIcon />,
      },
      {
        segment: "view-banners",
        title: "View All Banners",
        icon: <FolderIcon />,
      },
    ],
  },
  {
    segment: "tournament-manager",
    title: "Tournament Manager",
    icon: <TourIcon />,
    children: [
      {
        segment: "add-tournament",
        title: "Add Tournament",
        icon: <FolderIcon />,
      },
      {
        segment: "view-tournament",
        title: "View Tournament",
        icon: <FolderIcon />,
      },
      {
        segment: "user-tournament/register",
        title: "Registered User",
        icon: <FolderIcon />,
      },
    ],
  },
  {
    segment: "user-manager",
    title: "User Manager",
    icon: <PeopleOutlineIcon />,
    children: [
      {
        segment: "ground-owners",
        title: "View Ground Owner ",
        icon: <FolderIcon />,
      },
      {
        segment: "user-registered",
        title: "View Users",
        icon: <FolderIcon />,
      },
    ],
  },
  {
    segment: "support-manager",
    title: "Support Manager",
    icon: <SupportAgentIcon />,
    children: [
      {
        segment: "user-support",
        title: "User Support",
        icon: <FolderIcon />,
      },
    ],
  },
  {
    segment: "notification-manager",
    title: "Notification Manager",
    icon: <NotificationsActiveIcon />,
    children: [
      {
        segment: "push-notification",
        title: "App Notification",
        icon: <FolderIcon />,
      },
    ],
  },
];

function DashboardLayoutCustomThemeSwitcher(props) {
  const { window } = props;

  // Remove this const when copying and pasting into your project.
  const demoWindow = window !== undefined ? window() : undefined;

  return (
    <>
      <Navbar />
    </>
  );
}

DashboardLayoutCustomThemeSwitcher.propTypes = {
  window: PropTypes.func,
};

DashboardLayoutCustomThemeSwitcher.propTypes = {
  window: PropTypes.func,
};

const demoTheme = createTheme({
  cssVariables: {
    colorSchemeSelector: "data-toolpad-color-scheme",
  },

  colorSchemes: { light: true },

  components: {
    MuiStack: {
      styleOverrides: {
        root: {
          display: "flex",
          alignItems: "center",
        },
      },
      
    },

    
    MuiCssBaseline: {
      styleOverrides: {
        body: {
          "& .MuiBox-root": {
            ".css-1a2ef5c": {
              marginTop: "1rem",
            },
          },
        },
      },
    },

  },

  breakpoints: {
    values: {
      xs: 0,
      sm: 600,
      md: 600,
      lg: 1200,
      xl: 1536,
    },
  },
});

function DemoPageContent({ pathname }) {
  return (
    <Box
      sx={{
        py: 4,
        display: "flex",
        flexDirection: "column",
        alignItems: "center",
        textAlign: "center",
      }}
    ></Box>
  );
}

DemoPageContent.propTypes = {
  pathname: PropTypes.string.isRequired,
};

function DashboardLayoutNavigationNested(props) {
  const { window } = props;
  const location = useLocation(); // Provides the current location
  const navigate = useNavigate();

  const router = React.useMemo(() => {
    return {
      pathname: location.pathname, // Get the current path dynamically
      navigate: (path) => navigate(path),
      searchParams: new URLSearchParams(location.search), // Parse query parameters
    };
  }, [navigate, location]);

 

  return (
    // preview-start
    <AppProvider
      navigation={navigation}
     router={router}
      theme={demoTheme}
      branding={{
        
        logo: (
        
            <img src={logo}  alt="one7sports logo" />
       
        ),
        title: "",
      }}
    >
      {/* <DashboardLayout>

      </DashboardLayout> */}

      <DashboardLayout
        slots={{
          toolbarActions: DashboardLayoutCustomThemeSwitcher,
        }}
      >
        <Box>
          <Outlet />
        </Box>
      </DashboardLayout>
    </AppProvider>
    // preview-end
  );
}

DashboardLayoutNavigationNested.propTypes = {
  /**
   * Injected by the documentation to work in an iframe.
   * Remove this when copying and pasting into your project.
   */
  window: PropTypes.func,
};

export default DashboardLayoutNavigationNested;

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: Dashboard

Search keywords:

@ashishjaswal2002 ashishjaswal2002 added bug 🐛 Something doesn't work status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Nov 22, 2024
@michelengelen
Copy link
Member

Where did you get this from? Is it a template from the mui store?

@michelengelen michelengelen added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Nov 22, 2024
@ashishjaswal2002
Copy link
Author

It is a component from material ui https://mui.com/toolpad/core/react-dashboard-layout/

@github-actions github-actions bot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed status: waiting for author Issue with insufficient information labels Nov 22, 2024
@flaviendelangle
Copy link
Member

This is a Toolpad component (which is a product of our company), I'm transfering to the correct repo 👍

@flaviendelangle flaviendelangle transferred this issue from mui/mui-x Nov 22, 2024
@ashishjaswal2002
Copy link
Author

ashishjaswal2002 commented Nov 22, 2024

Screenshot 2024-11-22 at 4 36 49 PM So how can i access a tag im material ui app provider so i can change the route.

@bharatkashyap
Copy link
Member

bharatkashyap commented Nov 22, 2024

What you're looking for is the branding prop of the AppProvider. You can do something like:

 branding={{
    logo: <img src="https://mui.com/static/logo.png" alt="MUI logo" />,
    title: 'MUI',
  }}

Ref this demo: https://mui.com/toolpad/core/react-dashboard-layout/#branding

@bharatkashyap bharatkashyap removed bug 🐛 Something doesn't work status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Nov 22, 2024
@bharatkashyap bharatkashyap changed the title Dashboard Layout [DashboardLayout] How to modify the src of the logo image Nov 22, 2024
@ashishjaswal2002
Copy link
Author

@bharatkashyap please read the issue again.

@ashishjaswal2002
Copy link
Author

ashishjaswal2002 commented Nov 22, 2024

Let me mention Again
I mentioned the Dashboard Layout code above
When i click on the image it redirects to the home page and on inspect i can see anchor tag . which is redirecting to the home page '/' what i want is that i want to redirect to the custom route when user click on the image i just want to change the href link. This is my issue.
So how can i code so it redirects to the '/custom-route'.

in.

  branding={{
     logo: (
     <Link to="/dashboard'>
    </img src="https://mui.com/stxZXatic/logo.png" alt="MUI logo" />
     </Link>)
     title: 'MUI',
}}

If i set like this it is giving me anchor tag erros or a tag inside descendant errors......

@bharatkashyap bharatkashyap changed the title [DashboardLayout] How to modify the src of the logo image [DashboardLayout] How to modify the default AppBar branding redirect route Nov 22, 2024
@bharatkashyap bharatkashyap changed the title [DashboardLayout] How to modify the default AppBar branding redirect route [DashboardLayout] How to modify the default AppBar branding link Nov 22, 2024
@ashishjaswal2002
Copy link
Author

When will i get the solution for this?

@bharatkashyap
Copy link
Member

Understood. The default route is set in the Link component here https://github.com/mui/toolpad/blob/master/packages/toolpad-core/src/DashboardLayout/DashboardLayout.tsx#L369 and I don't see a way to change it via props currently

We could potentially add a branding.home property to the branding prop and let that be the default before falling back to /. Wdyt @apedroferreira? Did I miss a possible way to customize this route?

@bharatkashyap bharatkashyap added the new feature New feature or request label Nov 22, 2024
@bharatkashyap bharatkashyap changed the title [DashboardLayout] How to modify the default AppBar branding link [DashboardLayout] Modify the default AppBar branding link Nov 22, 2024
@ashishjaswal2002
Copy link
Author

how ?

branding.home ={{

}}

@ashishjaswal2002
Copy link
Author

ashishjaswal2002 commented Nov 22, 2024

@bharatkashyap is there any other way?
what should i do now? please give me guidance

@bharatkashyap
Copy link
Member

@bharatkashyap is there any other way? what should i do now? please give me guidance

Hi Ashish, the fastest way to see this feature land would be to contribute a PR that adds branding.home - feel free to create one and we can gather everyone else's opinions there, if it merges we can add it to the next version which is planned to be released today

@ashishjaswal2002
Copy link
Author

For this i have to clone repo?
please give me guidance step by steps

@bharatkashyap
Copy link
Member

Yes, clone the repo, make the changes on your local, push it to your fork on a new branch and then create a Pull Request

@apedroferreira
Copy link
Member

Understood. The default route is set in the Link component here https://github.com/mui/toolpad/blob/master/packages/toolpad-core/src/DashboardLayout/DashboardLayout.tsx#L369 and I don't see a way to change it via props currently

We could potentially add a branding.home property to the branding prop and let that be the default before falling back to /. Wdyt @apedroferreira? Did I miss a possible way to customize this route?

Yeah, currently there's no way to override this.
The quickest way to allow for it would probably be to provide a new slot so that the whole link and its content in the header can be overridden.
And then if eventually we find more use cases for it or this becomes a common use case, we could add something like a homeUrl to the branding.

@ashishjaswal2002
Copy link
Author

@apedroferreira when it is going to be drop?

@bharatkashyap bharatkashyap added scope: toolpad-core Abbreviated to "core" component: layout This is the name of the generic UI component, not the React module! labels Nov 22, 2024
@ashishjaswal2002
Copy link
Author

@bharatkashyap I’m a bit busy at the moment and don’t have time to contribute to the MUI project.

@ashishjaswal2002
Copy link
Author

When will it be dropped, or is there a way to customize the branding home link? @apedroferreira

@apedroferreira
Copy link
Member

When will it be dropped, or is there a way to customize the branding home link? @apedroferreira

Hey, we've planned the fixes for the next release of @toolpad/core, v0.11.0
We will both add a homeUrl property to branding that can be customized, and a slot to fully override the link in the header with any custom component.

@ashishjaswal2002
Copy link
Author

Like in a week or days?

@prakhargupta1
Copy link
Member

prakhargupta1 commented Nov 26, 2024

Like in a week or days?

It depends on the planned features, but roughly we release in every 2-3 weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: layout This is the name of the generic UI component, not the React module! new feature New feature or request scope: toolpad-core Abbreviated to "core"
Projects
Status: Planned
Development

No branches or pull requests

6 participants