Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store password as hash in .env #35

Open
Syr0 opened this issue Oct 16, 2024 · 2 comments
Open

Store password as hash in .env #35

Syr0 opened this issue Oct 16, 2024 · 2 comments

Comments

@Syr0
Copy link

Syr0 commented Oct 16, 2024

Storing the password as plain is horrible.

@syngron
Copy link

syngron commented Oct 19, 2024

I just removed the hashPassword function in this line and used the hash directly as password:
https://github.com/mtrossbach/noah-mqtt/blob/main/internal/growatt/client.go#L42

@mtrossbach
Copy link
Owner

While using the hashed password works in specific cases, it's not a sustainable solution for all users due to the complexities of Growatt's password hashing. Their non-standard and region-specific algorithm makes it difficult for most users to maintain them correctly if Growatt decides to change it (again).

Providing a way for users to hash their passwords would be ideal, but requires further investigation into Growatt's hashing methods for each region and API version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants