Fix crash on WinPE #163
Open
Fix crash on WinPE #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Native RAM disks, e.g. as are used in WinPE environments, have other characteristics than regular filesystems such as NTFS. For instance, re-opening files with NtOpenFile is buggy. This commit checks whether a volume is a RAM disk through the NT object the drive letter link refers to. This seems to be the only reliable method of checking whether a volume is a native RAM disk.
Calling mmap on a file stored on a volume with buggy file re-opening currently bugchecks. This commit solves this by using the init_reopen_attr helper function. Fixes msys2#160
|
I've submitted this upstream. |
For lurkers, the submission can be seen here: https://inbox.sourceware.org/cygwin-patches/[email protected]/ |
|
It might be a while before I can address the review comments, but the patch does work as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Native RAM disks, e.g. as are used in WinPE environments, have other characteristics than regular filesystems such as NTFS. For instance, re-opening files with
NtOpenFileis buggy. This can cause a bugcheck with the current implementation ofmmap.The first commit adds RAM disk detection. The second commit uses
init_reopen_attrinmmapto circumvent the re-opening bug.Fixes #160