qt5: restore some MINGW32 packages #22130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following a discussion on Discord, see: https://www.discord.com/channels/792780131906617355/794220101741838401/1283064557660803083 brought about by msys2@a4f0579 I suggested to restore for a while a couple of Qt5 packages that the [Mudlet](https://github.com/Mudlet/Mudlet) project I code for uses for its 32-Bit Windows builds until we have migrated as many of our Windows users up to 64-Bit builds as possible. I was hoping that one of the MSYS2+Mingw-w64 team would have been able to find the time to make this change but after a couple of weeks of nothing happening I have decided to try and do it myself. Signed-off-by: Stephen Lyons <[email protected]>
SlySven
commented
Oct 6, 2024
|
Is there an upstream issue where one can track the move to 64bit? |
|
Yep, here: Mudlet/Mudlet#7460 |
|
Would it be possible to migrate to 64 bit now instead of adding 32 bit qt5? That discord comment was a month old from now. |
|
Unfortunately no, because we need to do at least one 32bit update that will guide users towards installing 64bit. If we dont do this, the vast majority of our userbase will never receive an update for the next version. |
|
Thanks. We'll restore them for now and re-evaluate in 3 months. |
|
Appreciated! It would also be nice to know in the future if such packages are planned to be dropped by the project in advance so that we can plan for this. |
SlySven
added a commit
to SlySven/Mudlet
that referenced
this pull request
Oct 10, 2024
#### Brief overview of PR changes/additions Add three libraries to those included in the packaged application for 32-Bits Windows builds. They not longer seem to be detected by the `ntldd` tool (even though the 64-Bits one does does so) - whether the loading mechanism has changed so that they are loaded dynamically now so no longer show up in the 32-Bit build seems a possible but weird explaination given that some testing I've done with 64 Bit builds in both Qt 5 and 6 do show them. #### Motivation for adding to Mudlet This is essential for getting 32-Bit builds working again after msys2/MINGW-packages#22130 restored two Qt5 packages that had gotten dropped. #### Other info (issues closed, discussion etc) This was first reported on Discord by **@bcross32** in the Discord **[#mudlet-testing](https://www.discord.com/channels/283581582550237184/427919962561052673/1293540881818845215)** channel at 2024/10/09 11:49 UTC and also by **@karahd** (gesslar) in the **[#help](https://canary.discord.com/channels/283581582550237184/283582068334526464/1293753289116221543)** one at 2024/10/10 01:53 UTC. Signed-off-by: Stephen Lyons <[email protected]>
SlySven
added a commit
to Mudlet/Mudlet
that referenced
this pull request
Oct 10, 2024
#### Brief overview of PR changes/additions Add three libraries to those included in the packaged application for 32-Bits Windows builds. They not longer seem to be detected by the `ntldd` tool (even though the 64-Bits one does does so) - whether the loading mechanism has changed so that they are loaded dynamically now so no longer show up in the 32-Bit build seems a possible but weird explaination given that some testing I've done with 64 Bit builds in both Qt 5 and 6 do show them. #### Motivation for adding to Mudlet This is essential for getting 32-Bit builds working again after msys2/MINGW-packages#22130 restored two Qt5 packages that had gotten dropped. #### Other info (issues closed, discussion etc) This was first reported on Discord by **@bcross32** in the Discord **[#mudlet-testing](https://www.discord.com/channels/283581582550237184/427919962561052673/1293540881818845215)** channel at 2024/10/09 11:49 UTC and also by **@karahd** (gesslar) in the **[#help](https://canary.discord.com/channels/283581582550237184/283582068334526464/1293753289116221543)** one at 2024/10/10 01:53 UTC. --------- Signed-off-by: Stephen Lyons <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a discussion on Discord, see:
https://www.discord.com/channels/792780131906617355/794220101741838401/1283064557660803083 brought about by a4f0579 I suggested to restore for a while a couple of Qt5 packages that the Mudlet project I code for uses for its 32-Bit Windows builds until we have migrated as many of our Windows users up to 64-Bit builds as possible.
I was hoping that one of the MSYS2+Mingw-w64 team would have been able to find the time to make this change but after a couple of weeks of nothing happening I have decided to try and do it myself.