Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomMode view frame issue #103

Open
songjisj opened this issue Aug 11, 2015 · 1 comment
Open

CustomMode view frame issue #103

songjisj opened this issue Aug 11, 2015 · 1 comment

Comments

@songjisj
Copy link

Now MRProgress forces the provided custom view to be a square if using CustomMode, related code in manualLayoutSubviews in MRProgressOverlayView:

modeViewFrame = CGRectMake(modePadding, y, innerViewWidth, innerViewWidth);

Could you use the height which the custom view provides? Suggested change like:

modeViewFrame = CGRectMake(modePadding, y, innerViewWidth, self.modeView.frame.size.height);

Thank you.

@mrackwitz
Copy link
Owner

You're right. Using the provided height would make much more sense here. Are you eager to put together a PR for that? That would be welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants