Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runtime singleton should be refactored out #38

Open
mpounsett opened this issue Jan 21, 2022 · 0 comments
Open

Runtime singleton should be refactored out #38

mpounsett opened this issue Jan 21, 2022 · 0 comments
Milestone
2.x

Comments

@mpounsett
Copy link
Owner

The nagiosplugin.runtime.Runtime class is implemented as a singleton. This is an anti-pattern, and doesn't seem to serve any purpose, so should be refactored out of the code.

Since it's possible the side-effects this causes are relied upon by existing code, this should be done in a 2.x release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.x
Development

No branches or pull requests
1 participant
@mpounsett