Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"AMO API base URL" must be specified even though docs say it has a default #3164

Open
EvHaus opened this issue Jun 7, 2024 · 1 comment
Open

Comments

@EvHaus
Copy link

EvHaus commented Jun 7, 2024

Is this a feature request or a bug?

After upgrading from v7 to v8, the .sign() command no longer works for me due to this error:

Invalid AMO API base URL: undefined

My code is:

import webExt from 'web-ext';

await webExt.cmd.sign({
      apiKey: '<hidden>',
      apiSecret: '<hidden>',
      artifactsDir: '<hidden>',
      channel: 'unlisted',
      sourceDir: '<hidden>',
})

I can overcome this error by adding:

amoBaseUrl: 'https://addons.mozilla.org/api/v5/'

But the docs say I shouldn't need to do that as this is already the default.

What is the current behavior?

If no amoBaseUrl is specified, error is thrown.

What is the expected or desired behavior?

If no amoBaseUrl is specified, the default is used.

Version information (for bug reports)

  • Firefox version: N/A
  • Your OS and version: MacOS 14.5 (23F79)
  • Paste the output of these commands:
node --version && npm --version && web-ext --version

v20.14.0
10.7.0
8.0.0
@willdurand
Copy link
Member

Ha, indeed. I suppose we can set a default value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants