You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've noticed that the test262.properties file is outdated today. The diffs are surprising though:
- from/calling-from-valid-1-noStrict.js non-strict Spec pretty clearly says this should be undefined+ from/calling-from-valid-1-noStrict.js {compiled-non-strict,interpreted-non-strict} Spec pretty clearly says this should be undefined
So I am not sure if just rerunning and commiting is the right fix. I guess this might be related to the optimization level of #1754 ?
The text was updated successfully, but these errors were encountered:
Yes, re-running and re-committing is the right fix, with a simple PR.
However, it might be worth looking at that PR -- there is a lot of complex
logic in there for calculating how to report on the test failures in the
four remaining test modes (non strict, strict, interpreted, and optimized)
and perhaps I missed some logic -- I think that both cases are the same,
but previously we must have consolidated them into one "non-strict" case
and now we don't.
On Fri, Dec 20, 2024 at 9:31 AM Andrea Bergia ***@***.***> wrote:
I've noticed that the test262.properties file is outdated today. The diffs
are surprising though:
- from/calling-from-valid-1-noStrict.js non-strict Spec pretty clearly says this should be undefined+ from/calling-from-valid-1-noStrict.js {compiled-non-strict,interpreted-non-strict} Spec pretty clearly says this should be undefined
So I am not sure if just rerunning and commiting is the right fix. I guess
this might be related to the optimization level of #1754
<#1754> ?
—
Reply to this email directly, view it on GitHub
<#1764>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD7I23YDHIZSEQBRCYGF4T2GRH6RAVCNFSM6AAAAABT7RKX7WVHI2DSMVQWIX3LMV43ASLTON2WKOZSG42TGMJWHE4DONQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
I've noticed that the test262.properties file is outdated today. The diffs are surprising though:
So I am not sure if just rerunning and commiting is the right fix. I guess this might be related to the optimization level of #1754 ?
The text was updated successfully, but these errors were encountered: