-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default Parameters + Destructuring - Pending items #1641
Comments
@0xe any chance you'll be picking up this one not that the previous part has been merged? |
Yep. I'm planning on starting with destructuring with defaults in for loops. |
Looking to add support for destructuring with defaults in for loops, I found some problems in how default values were transformed. I've created a PR to fix those first: #1708. |
FIX: Transform default values correctly in destructuring This addresses some of the issues in #1641
Looks like we have made progress since the last time we updated this issue. Can anyone update where we are with this? I'd like to decide if we're going to fix this in the next week or so or move it to a new release. |
Sorry, this fell off the radar a bit. I'm still working on fixing this but won't be able to make it by next week. |
Address items pending from #1640
This should throw a TypeError as
[Symbol.iterator]
is not implemented for that object on the rhs, instead uses defaults to return3
.And this should work because we call into iterator to get the default values. Instead we throw a NPE currently.
The text was updated successfully, but these errors were encountered: