From 29c9818bb014ec1791da1e87360df2bfc4a8b0c3 Mon Sep 17 00:00:00 2001 From: Lauren Zugai Date: Thu, 26 Sep 2024 15:44:17 -0500 Subject: [PATCH] task(CAD): Update 'Start browsing' to 'Manage your account' Because: * 'Start browsing' is confusing since it takes users to account settings This commit: * Updates the copy to 'Manage your account' fixes FXA-10376 --- packages/functional-tests/pages/connectAnotherDevice.ts | 4 ++-- .../app/scripts/templates/connect_another_device.mustache | 2 +- .../fxa-content-server/app/scripts/templates/ready.mustache | 2 +- packages/fxa-content-server/app/tests/spec/views/ready.js | 2 +- packages/fxa-settings/src/components/Ready/en.ftl | 2 +- packages/fxa-settings/src/components/Ready/index.tsx | 4 ++-- .../ResetPasswordWithRecoveryKeyVerified/index.test.tsx | 2 +- packages/fxa-shared/metrics/glean/fxa-ui-metrics.yaml | 2 +- packages/fxa-shared/metrics/glean/web/cad.ts | 3 ++- 9 files changed, 12 insertions(+), 11 deletions(-) diff --git a/packages/functional-tests/pages/connectAnotherDevice.ts b/packages/functional-tests/pages/connectAnotherDevice.ts index b901c162b3a..0847d59e5bd 100644 --- a/packages/functional-tests/pages/connectAnotherDevice.ts +++ b/packages/functional-tests/pages/connectAnotherDevice.ts @@ -35,8 +35,8 @@ export class ConnectAnotherDevicePage extends BaseLayout { ); } - get startBrowsingButton() { - return this.page.getByRole('link', { name: 'Start browsing' }); + get manageYourAccountButton() { + return this.page.getByRole('link', { name: 'Manage your account' }); } get installFxDesktop() { diff --git a/packages/fxa-content-server/app/scripts/templates/connect_another_device.mustache b/packages/fxa-content-server/app/scripts/templates/connect_another_device.mustache index 78371f7446c..34a46f691cd 100644 --- a/packages/fxa-content-server/app/scripts/templates/connect_another_device.mustache +++ b/packages/fxa-content-server/app/scripts/templates/connect_another_device.mustache @@ -60,7 +60,7 @@ {{#t}}Connect another device{{/t}}
- {{#t}}Start browsing{{/t}} + {{#t}}Manage your account{{/t}}
{{/isSignedIn}}

diff --git a/packages/fxa-content-server/app/scripts/templates/ready.mustache b/packages/fxa-content-server/app/scripts/templates/ready.mustache index f0da7c570a9..ab7ffac4f10 100644 --- a/packages/fxa-content-server/app/scripts/templates/ready.mustache +++ b/packages/fxa-content-server/app/scripts/templates/ready.mustache @@ -11,7 +11,7 @@ {{#isSync}}

{{{escapedReadyToSyncText}}}

- +
{{/isSync}} diff --git a/packages/fxa-content-server/app/tests/spec/views/ready.js b/packages/fxa-content-server/app/tests/spec/views/ready.js index 83ddc09b5e1..6a41087623e 100644 --- a/packages/fxa-content-server/app/tests/spec/views/ready.js +++ b/packages/fxa-content-server/app/tests/spec/views/ready.js @@ -212,7 +212,7 @@ describe('views/ready', function () { }); }); - it('shows the `Start browsing` for Sync', () => { + it('shows the `Manage your account` for Sync', () => { createView(VerificationReasons.SIGN_UP); sinon.stub(relier, 'isSync').callsFake(() => true); diff --git a/packages/fxa-settings/src/components/Ready/en.ftl b/packages/fxa-settings/src/components/Ready/en.ftl index 346704d2a74..1906ed0facb 100644 --- a/packages/fxa-settings/src/components/Ready/en.ftl +++ b/packages/fxa-settings/src/components/Ready/en.ftl @@ -2,7 +2,7 @@ reset-password-complete-header = Your password has been reset ready-complete-set-up-instruction = Complete setup by entering your new password on your other { -brand-firefox } devices. -ready-start-browsing-button = Start browsing +manage-your-account-button = Manage your account # This is a string that tells the user they can use whatever service prompted them to reset their password or to verify their email # Variables: # { $serviceName } represents a product name (e.g., Mozilla VPN) that will be passed in as a variable diff --git a/packages/fxa-settings/src/components/Ready/index.tsx b/packages/fxa-settings/src/components/Ready/index.tsx index d743fc75409..04a453453df 100644 --- a/packages/fxa-settings/src/components/Ready/index.tsx +++ b/packages/fxa-settings/src/components/Ready/index.tsx @@ -124,9 +124,9 @@ const Ready = ({

- +
diff --git a/packages/fxa-settings/src/pages/ResetPassword/ResetPasswordWithRecoveryKeyVerified/index.test.tsx b/packages/fxa-settings/src/pages/ResetPassword/ResetPasswordWithRecoveryKeyVerified/index.test.tsx index 5eaf0a4a1f6..23c20c619cd 100644 --- a/packages/fxa-settings/src/pages/ResetPassword/ResetPasswordWithRecoveryKeyVerified/index.test.tsx +++ b/packages/fxa-settings/src/pages/ResetPassword/ResetPasswordWithRecoveryKeyVerified/index.test.tsx @@ -73,7 +73,7 @@ describe('ResetPasswordWithRecoveryKeyVerified', () => { // bundle = await getFtlBundle('settings'); // }); - const startBrowsingText = 'Start browsing'; + const startBrowsingText = 'Manage your account'; const signedInText = 'You’re now ready to use account settings'; const singedOutText = 'Your account is ready!'; const syncText = diff --git a/packages/fxa-shared/metrics/glean/fxa-ui-metrics.yaml b/packages/fxa-shared/metrics/glean/fxa-ui-metrics.yaml index 02a8ffb53c9..761484014f7 100644 --- a/packages/fxa-shared/metrics/glean/fxa-ui-metrics.yaml +++ b/packages/fxa-shared/metrics/glean/fxa-ui-metrics.yaml @@ -1727,7 +1727,7 @@ cad: startbrowsing_submit: type: event description: | - User clicks "Start browsing" on "Connect another device page" + User clicks "Manage your account" on "Connect another device page". This CTA used to be "Start browsing". send_in_pings: - events notification_emails: diff --git a/packages/fxa-shared/metrics/glean/web/cad.ts b/packages/fxa-shared/metrics/glean/web/cad.ts index df1aaca15ee..3799c5abbd4 100644 --- a/packages/fxa-shared/metrics/glean/web/cad.ts +++ b/packages/fxa-shared/metrics/glean/web/cad.ts @@ -7,7 +7,8 @@ import EventMetricType from '@mozilla/glean/private/metrics/event'; /** - * User clicks "Start browsing" on "Connect another device page" + * User clicks "Manage your account" on "Connect another device page". This CTA + * used to be "Start browsing". * * Generated from `cad.startbrowsing_submit`. */