Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out if we can remove these JS Violation warnings #710

Open
humphd opened this issue Apr 12, 2017 · 3 comments
Open

Figure out if we can remove these JS Violation warnings #710

humphd opened this issue Apr 12, 2017 · 3 comments

Comments

@humphd
Copy link

humphd commented Apr 12, 2017

[Violation] 'readystatechange' handler took 678ms
RemoteFiler.js:21 [Violation] 'message' handler took 193ms
[Violation] Forced reflow while executing JavaScript took 78ms
RemoteFiler.js:21 [Violation] 'message' handler took 274ms
[Violation] Forced reflow while executing JavaScript took 70ms
compatibility.js:35 [Violation] 'load' handler took 208ms
[Violation] Forced reflow while executing JavaScript took 89ms
[Violation] Forced reflow while executing JavaScript took 41ms
[Violation] Forced reflow while executing JavaScript took 35ms
[Violation] Forced reflow while executing JavaScript took 33ms
[Violation] Forced reflow while executing JavaScript took 39ms

Noticing this for the first time tonight in Chrome. It's related to us using MessageChannel to send things over to the iframe and back, and I guess blocking on it returning? We should see if we can deal with any of it.

@edyedy123
Copy link

Hey, Id like to give fixing this a try.

@humphd
Copy link
Author

humphd commented Apr 17, 2017

@edyedy123 this is not going to be an easy bug to fix, FYI. You are welcome to try it, but I really have no idea how to get you started on it. If you still want this, let me know; but you might also have an easier time with something else. Let me know.

@edyedy123
Copy link

Ok, I'Il try somthing else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants