Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

Routine matching is broken and too aggressive #1908

Open
ianb opened this issue Aug 10, 2020 · 1 comment
Open

Routine matching is broken and too aggressive #1908

ianb opened this issue Aug 10, 2020 · 1 comment

Comments

@ianb
Copy link
Contributor

ianb commented Aug 10, 2020

To reproduce:

  • Create a routine named "test"
  • Try "this is a test" or "search for test" or anything with the word "test"

It shouldn't match at all, but it is also broken when it matches. The problematic code is here: https://github.com/mozilla-extensions/firefox-voice/blob/master/extension/background/intentRunner.js#L284-L305

I don't understand what handler.runRoutine is supposed to be about, and it actually breaks things. I think I was trying to be clever, but the cleverness was never used.

Maybe the entire logic needs to be removed.

@Simpcyclassy
Copy link
Collaborator

I was about to raise an issue on the page name routine being broken as well as I just explained to you and saw this. Looks like it's a related issue affecting #1813

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants