You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.
I don't understand what handler.runRoutine is supposed to be about, and it actually breaks things. I think I was trying to be clever, but the cleverness was never used.
Maybe the entire logic needs to be removed.
The text was updated successfully, but these errors were encountered:
I was about to raise an issue on the page name routine being broken as well as I just explained to you and saw this. Looks like it's a related issue affecting #1813
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
To reproduce:
It shouldn't match at all, but it is also broken when it matches. The problematic code is here: https://github.com/mozilla-extensions/firefox-voice/blob/master/extension/background/intentRunner.js#L284-L305
I don't understand what
handler.runRoutine
is supposed to be about, and it actually breaks things. I think I was trying to be clever, but the cleverness was never used.Maybe the entire logic needs to be removed.
The text was updated successfully, but these errors were encountered: