You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One of the goals of the certificate chain cleaner is to ensure there's at least one trust anchor in the cleaned chain, so I'm wondering at the order of checks at
Would it be better to put the isTrustRoot(chain[i]) check inside the if (isValidLink(chain[i], chain[i - 1])) block, rather than before it? Otherwise, it seems like trustedChain could be set to true without a verified trust anchor in the chain.
Apologies if this is a non-issue, because I have a feeling there's probably something I've overlooked 😄 and thanks for the library!
The text was updated successfully, but these errors were encountered:
One of the goals of the certificate chain cleaner is to ensure there's at least one trust anchor in the cleaned chain, so I'm wondering at the order of checks at
AndroidPinning/src/org/thoughtcrime/ssl/pinning/CertificateChainCleaner.java
Line 50 in 9098125
Would it be better to put the
isTrustRoot(chain[i])
check inside theif (isValidLink(chain[i], chain[i - 1]))
block, rather than before it? Otherwise, it seems liketrustedChain
could be set to true without a verified trust anchor in the chain.Apologies if this is a non-issue, because I have a feeling there's probably something I've overlooked 😄 and thanks for the library!
The text was updated successfully, but these errors were encountered: