-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grammar Parse Error Token "[[" in Extension Addition Group #73
Comments
This work may support some extension syntax - but in general, there are ASN.1 features that a sane person would never use, and, of course, many not-so-sane standard writers (who Marshall Rose named "goers" as opposed to "doers" ;) are all too happy to use, mostly in a wrong way... In short, I'm sorry - but I don't think I know how to deal with that stuff. :-( |
I compiled 36331 (took asn files from wireshark source) using another fork of the compiler. The required branch is called velichkov_s1ap_plus_option_group_plus_adding_trailing_ull. Everything compiled without errors. There were some warnings, but the messages are decoded. |
brchiu@3d76a03 has fix this issue,will you merge it? |
For what it's worth I rebased brchiu and other OAI changes from branch https://gitlab.eurecom.fr/oai/asn1c/-/tree/velichkov_s1ap_plus_option_group branch onto mouse's vlm_master. A fork is at https://github.com/ruffyontheweb/asn1c/tree/oai_on_vlm_master Using oai_on_vlm_master I am able to generate code from F1, RRC, and NGAP asn1 definitions. I've hand checked the merge and it seems to include all the changes to generate properly. I checked the refactored per/aper/uper files in the skeletons directory. There are some differences in some of the files in skeletons, but their meaning is beyond me so I kept what is in vlm_master. The rebased branch seems to have the same performance as the https://gitlab.eurecom.fr/oai/asn1c/-/tree/velichkov_s1ap_plus_option_group branch. |
@ruffyontheweb can you submit a PR? |
But it looks like make check does not pass. Log file attached to the PR. |
I am using 36331-g40.asn1 and get the error:
ASN.1 grammar parse error near 36331-g40.asn1:2886 (token "[["): syntax error, unexpected TOK_VBracketLeft
Cannot parse "36331-g40.asn1"
Your fork has been mentioned in other issues as having a workable implementation of the extension addition group syntax (348, 317) but I'm still getting the same error others have in the past. One difference I've noticed in the newer versions of the .asn1 files from the versions from when you added extension addition group handling, is that the extension addition group syntax parsing errors are within a CHOICE this time and perhaps they weren't before.
I would greatly appreciate any guidance.
The text was updated successfully, but these errors were encountered: