Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The global_ param to basic_qos is not set on RobustChannel reopen #583

Open
jeff-foster-trabon opened this issue Sep 26, 2023 · 1 comment · May be fixed by #585
Open

The global_ param to basic_qos is not set on RobustChannel reopen #583

jeff-foster-trabon opened this issue Sep 26, 2023 · 1 comment · May be fixed by #585

Comments

@jeff-foster-trabon
Copy link

In the call to aiormq.Channel.basic_qos inside RobustChannel._on_open, the values that were stored in self._prefetch_count and self._prefetch_size from the call to set_qos are passed, but not self._global_qos:

await channel.basic_qos(
    prefetch_count=self._prefetch_count,
    prefetch_size=self._prefetch_size,
)

Is this intentional? I don't know why you wouldn't want to pass global_ as well, like:

await channel.basic_qos(
    prefetch_count=self._prefetch_count,
    prefetch_size=self._prefetch_size,
    global_=self._global_qos,
)
@mosquito
Copy link
Owner

Don’t you want to open PR?

@jeff-foster-trabon jeff-foster-trabon linked a pull request Oct 2, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add global_ param to basic_qos call in RobustChannel _on_open method jeff-foster-trabon/aio-pika
2 participants
@mosquito @jeff-foster-trabon