Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global timeout for RobustConnection reconnect execution time #279

Open
phijor opened this issue Dec 16, 2019 · 0 comments
Open

Add global timeout for RobustConnection reconnect execution time #279

phijor opened this issue Dec 16, 2019 · 0 comments

Comments

@phijor
Copy link

phijor commented Dec 16, 2019

In a project we are building, we use RobustConnections to have a reliable way of reestablishing dropped connections. This works great, but sometimes we'd like still like to drop a connection after a certain timeout. For example, if a connection fails to be up after trying to reconnect for 5 minutes, we would like to consider it dead for good and propagate the error condition upwards in our stack. Right now, we use a watchdog task that hooks a RobustConnections close- and reconnect-callbacks to see whether the connection is back up in time, but that feels quite hacky.

I see that #259 adds some kind of global timeout to all operations, but I'm not quite sure if that includes what we'd need (nor do I completely understand the changeset). PR #247 proposes a similar feature, but tries to limit the number of attempts instead of the time taken to establish the connection. Both PRs seem to have stalled; is there a blocker for this where I could help out?

Is there a way this could be implemented easily? I could try and implement the execution timeout and open a pull request, however I do not have the required overview over the library (yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant