Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install NVM step needs pipefail #30

Open
pearj opened this issue Nov 24, 2020 · 1 comment · May be fixed by #49
Open

Install NVM step needs pipefail #30

pearj opened this issue Nov 24, 2020 · 1 comment · May be fixed by #49
Assignees
Labels

Comments

@pearj
Copy link

pearj commented Nov 24, 2020

Describe the bug
If the wget command fails for any reasons during the "Install NVM" the error is ignored, and then the check nvm version step fails later.

Expected behaviour
The "Install NVM" command should fail when the wget command fails instead of ignoring it

To Reproduce
Use bad proxy environment settings and wget will fail with return code 8.

Shell
Bash

Desktop (please complete the following information):

  • OS: RHEL 7.4
  • Ansible Version 2.9.10

Additional context
For bash this should be fixable by setting pipefail. Eg: https://blog.christophersmart.com/2019/09/28/using-pipefail-with-shell-module-in-ansible/

@morgangraphics morgangraphics self-assigned this Nov 24, 2020
@morgangraphics
Copy link
Owner

I've been doing quite a lot of work surrounding idempotency with this role. Thanks for pointing this out, I'll make it part of the work I am currently doing.

@morgangraphics morgangraphics linked a pull request Jun 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants