Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FamixJavaPackage >> #classes not working #435

Open
NicolasAnquetil opened this issue May 4, 2022 · 3 comments · May be fixed by #465
Open

FamixJavaPackage >> #classes not working #435

NicolasAnquetil opened this issue May 4, 2022 · 3 comments · May be fixed by #465

Comments

@NicolasAnquetil
Copy link
Contributor

should probably be removed
one can get all classes in a package with #types

@anneetien
Copy link
Contributor

Explanation is not clear. I hope that PR 465 solves the issue.

@anneetien
Copy link
Contributor

In fact this issue is not so easy to solve.
image
There are two container relationships between Package and Type (or Class). So there are two ways to get the classes from the package, using childEntities or types. And symetrically, it is possible to reach a package from a class using parentPackage or typeContainer. Depending how the model is built only one is used.

There are different possibilities to solve this issue:

  • derive one relation from the other, but a package can also contain Packages and a Class can be contained by Methods or Types. So not easy to choose which relation to derive.
  • remove the fact that a Package is a TWithTypes, which will remove the typeContainer relationship between a class and its package. It is certainly the better solution, but we need to check if it is compatible with VerveineJ.

@NicolasAnquetil @aranega @badetitou

@NicolasAnquetil
Copy link
Contributor Author

OK so PR #465 did not solve the issue apparently because the CI refused it

As we are using traits, we could redefine the #types method to call #childEntities+appropriate select but not sure it is worth the effort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants