Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need help understanding the role of the 'upfirdn' after the transpose_conv #8

Open
NoAchache opened this issue Nov 23, 2020 · 1 comment

Comments

@NoAchache
Copy link

Hello, I don't really get the point of the upfirdn (apart from reducing the dim of the height and width of x by one)?
How is the resample kernel chosen? ([1,3,3,1] in the code)
Why is the filter 4x4 (In the doc of the upfirdn of scipy, it says the filter should be 1-D https://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.upfirdn.html )?

@moono
Copy link
Owner

moono commented Nov 24, 2020

I think it's better asked on official_repo.
Those parameters were chosen by the author of original code. I just ported (wrapped) as tensorflow 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants