[seraphis] cryptonote_base: add account generators #8989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtnerd
approved these changes
Sep 10, 2023
jeffro256
reviewed
Sep 12, 2023
|
|
||
| inline crypto::public_key get_secondary_generator(const account_generator_era era) | ||
| { | ||
| if (era == account_generator_era::cryptonote) |
There was a problem hiding this comment.
Are they both meant to return G or is one supposed to return H?
There was a problem hiding this comment.
Both return G, it's for the spend and view keys (account generators not amount commitment generators).
There was a problem hiding this comment.
Sweet, just wanted to double check since Seraphis uses two different generators (I'm still woefully ignorant of the Crptonote multisig math).
jeffro256
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a PR in my 'upstreaming seraphis_lib project', it is not used anywhere yet.
account_generators.htocryptonote_basic.Explanation
Multisig account generation is the same for ringct and seraphis, so it's best to reuse all that code if possible. The only difference is the base generators used. Refactoring multisig accounts to depend on
account_generator_erawill allow seraphis to be easily supported.Future PRs
account_generator_era.