Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rm paragraph about locked outputs being used as decoys #2198

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

jeffro256
Copy link
Contributor

Locked outputs cannot be used as ring members since the protocol (by design) has no way of knowing which output is the "true" spend inside of a ring signature. Thus, the protocol only validates ring signatures where each member of the ring is properly unlocked.

@netlify
Copy link

netlify bot commented Oct 14, 2023

Deploy Preview for barolo-time-757cf9 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 33f7bcd
🔍 Latest deploy log https://app.netlify.com/sites/barolo-time-757cf9/deploys/653158b9c1e901000842dae8
😎 Deploy Preview https://deploy-preview-2198--barolo-time-757cf9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@erciccione erciccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the original file in english should be edited (_i18n/en/resources/moneropedia/unlocktime.md)

@jeffro256
Copy link
Contributor Author

Should I modify the commit now?

@jeffro256 jeffro256 force-pushed the rm_bad_tx_unlock_pg branch from ee3c4ae to 08907ee Compare October 19, 2023 00:38
Copy link
Contributor

@erciccione erciccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better to improve the commit description to specify what is being changed, but it's good to go.

@jeffro256 jeffro256 force-pushed the rm_bad_tx_unlock_pg branch from 08907ee to 33f7bcd Compare October 19, 2023 16:26
@jeffro256
Copy link
Contributor Author

Is this commit message better?

Copy link
Contributor

@erciccione erciccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's perfect, thanks.

@luigi1111 luigi1111 merged commit b6f5378 into monero-project:master Oct 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants