Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: verify redirect urls in downloads.yml #2197

Closed
wants to merge 1 commit into from

Conversation

plowsof
Copy link
Collaborator

@plowsof plowsof commented Oct 11, 2023

re-download all binaries using their redirect urls and confirm hashes.

displays a warning if files downloaded using the redirect urls do not match the hashes in downloads.yml

if there is a mis-match / or the redirects are not updated to point at the new files yet, the workflow will still be green and only produce warnings. re-running the workflow manually after site is deployed / redirects pointing to new files will remove the warnings.

example run showing a warning: https://github.com/plowsof/monero-site/actions/runs/6487887488

on workflow_dispatch: can be added to make running the workflow manually (if needed)

@netlify
Copy link

netlify bot commented Oct 11, 2023

Deploy Preview for barolo-time-757cf9 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 07a5795
🔍 Latest deploy log https://app.netlify.com/sites/barolo-time-757cf9/deploys/652715dd150ae80008c42a4b
😎 Deploy Preview https://deploy-preview-2197--barolo-time-757cf9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@plowsof
Copy link
Collaborator Author

plowsof commented Oct 22, 2023

The problem has been fixed. This workflow will prevent/detect the problem we had, however,

  • it needs to be run only when the DNS is updated (which comes some time after deployment) so we have to run the whole thing twice.
  • alot of duplication if we have a separate workflow for this check.
  • re-downloading all the files can add extra chances of network timeouts / the script failing (which happens often already)

i think it's better suited to be run on a contributors repo , 'after the fact' to confirm things are ok, rather than here on -site.. im leaning to close

@erciccione
Copy link
Contributor

i think it's better suited to be run on a contributors repo , 'after the fact' to confirm things are ok, rather than here on -site.. im leaning to close

Agree. Or a script on somebody's computer. No reason to add it on this repo.

@plowsof plowsof closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants