-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: Add support for Linux arm64 docker builds #3924
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add instructions to readme?
Updated :) |
Thanks, do you know how to squash your commits? |
Haven't done it before, would |
I usually do:
and then I set the commits that I want to squash to Edit: what you wrote should work too, I just noticed that you are in master branch so what I wrote doesn't apply. |
That takes care of that :D |
@zer0conf something went wrong |
Update README.md Added Docker instructions for static Linux arm64 builds relaunch check Update Makefile /bin/sh compatbility
Fixed, the squash reached a bit too far back |
Some unintended commits got added again, I think the issue is that you opened this from master branch. Will try to get this merged after the v0.18 release. |
Checked why docker-linux-static failed, stems from an error while cloning m4: |
yea i fixed it here #3969 |
Modifies Dockerfile.linux and Makefile to allow users to compile static arm64 linux builds.
For arm64 builds, an extra optional argument
--build--arg UBUNTU_VERSION=18.04
will need to be added to thedocker build
command. Runningmake
withdocker run
,release-static
would have to be changed torelease-static-linux-armv8
.