Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to multi-stage builds #80

Closed
timothyb89 opened this issue Jun 9, 2017 · 4 comments
Closed

Switch to multi-stage builds #80

timothyb89 opened this issue Jun 9, 2017 · 4 comments

Comments

@timothyb89
Copy link
Member

Docker now supports multi-stage builds: https://docs.docker.com/engine/userguide/eng-image/multistage-build/#use-multi-stage-builds

These would be a much better alternative to our ARG trickery.

@kornicameister
Copy link
Contributor

kornicameister commented Jul 18, 2017

I already done something similar here.
Might not be helpful at the moment, but I believe this might be a nice reference.

@kornicameister
Copy link
Contributor

@timothyb89 in order to make it happen in CI, I think you'd need to update docker there. In #121 I am trying to submit kibana image that is using multi-stage feature, but seems like from keyword for COPY operation is unknown.

@timothyb89
Copy link
Member Author

timothyb89 commented Jul 20, 2017 via email

@timothyb89
Copy link
Member Author

For reference later, Travis has a document for upgrading... https://docs.travis-ci.com/user/docker/#Installing-a-newer-Docker-version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants